-
Notifications
You must be signed in to change notification settings - Fork 30
Allow uint64 indices in dpt.take_along_axis
and dpt.put_along_axis
#1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_323 ran successfully. |
Overall this looks good to me, modulo nits. @vtavana It would be nice if an issue existed motivating this change. |
Created issue #1936 which is now resolved with this PR. Thank you, @ndgrigorian! |
Make tests more maintenance-friendly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ndgrigorian
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_331 ran successfully. |
This PR proposes allowing indices of type
uint64
intake_along_axis
andput_along_axis
.With current behavior, these functions build a list of indices using the default index type. If the input indices are
uint64
and the input array is of dimension greater than 1, when the padded indices are constructed, the function will fail if the default index type isint64
.Edit: Closes gh-1936