Skip to content

Backport to maintenance 0.18.x/gh 1893 #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 21, 2024
Merged

Backport to maintenance 0.18.x/gh 1893 #1907

merged 14 commits into from
Nov 21, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR backports gh-1893 which fixes gh-1892 to maintenance/0.18.x branch

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk added this to the 0.18.2 milestone Nov 21, 2024
@oleksandr-pavlyk oleksandr-pavlyk changed the base branch from master to maintenance/0.18.x November 21, 2024 15:41
@oleksandr-pavlyk
Add DPCTL_WITH_REDIST:BOOL=OFF option to cmake script
93bc422
@oleksandr-pavlyk
Add sycl8.lib to the list of valid libraries to look for
e960e69
@oleksandr-pavlyk
Support DPCTL_WITH_REDIST for DPCTLSyclInterface target
a14f900
@oleksandr-pavlyk
Support DPCTL_WITH_REDIST for Cython extensions
521016c
@oleksandr-pavlyk
Support DPCTL_WITH_REDIST for pybind11 modules in dpctl/utils
83fd6e2 
Deduplicated common steps among two pybind11 extensions in this
dpctl.utils

Fixed typo CUMAKE_CURRENT_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR
@oleksandr-pavlyk
Support DCPTL_WITH_REDIST for pybind11 extensions in dpctl.tensor
cfdca27
@oleksandr-pavlyk
Set DPCTL_WITH_REDIST=TRUE in conda build script
2094a2b
@oleksandr-pavlyk
Updated values to look for when setting SYCL_INCLUDE_DIR_HINT env var…
745508d 
…ible
@oleksandr-pavlyk
Remove leftover code from when dpctl has post-link and pre-unlink scr…
d924dcd 
…ipts
@oleksandr-pavlyk
Replace setting LD_LIBRARY_PATH with setting LIBRARY_PATH based on th…
1f71513 
…e preceding comment
@oleksandr-pavlyk
Correct typo: CMAKE_WITH_REDIST->DPCTL_WITH_REDIST
708b9b0
@oleksandr-pavlyk
Based on conda build verify messages, replace dpcpp-cpp-rt with intel…
3bc2e9d 
…-sycl-rt
@oleksandr-pavlyk
Set RELATIVE_PATH argument to build_dpctl_ext for pertinent modules
65360c3
@oleksandr-pavlyk
Replace setting LD_LIBRARY_PATH with setting LIBRARY_PATH based on th…
a295c11 
…e preceding comment
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the backport-to-maintenance-0.18.x/gh-1893 branch from b400782 to a295c11 Compare November 21, 2024 17:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.1=py310hdf72452_32 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 472f6ca into maintenance/0.18.x Nov 21, 2024
49 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the backport-to-maintenance-0.18.x/gh-1893 branch November 21, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.2
Development

Successfully merging this pull request may close these issues.

dpctl installed into virtual env fails to import
2 participants
@oleksandr-pavlyk @ndgrigorian