-
Notifications
You must be signed in to change notification settings - Fork 30
Bugfix/gh 1901 scan algo #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/gh 1901 scan algo #1902
Conversation
Use explicit type instead of auto for readability, save common sub-expression to a temporary variable. Move std::array variable declaration closer to its first use.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
The issue being fixed here was introduced recently, in gh-1896, and was not a part of any releases of |
This fixes gh-1901 Ensure that both start and end indices are within reduction bounds
596833e
to
d133a11
Compare
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_253 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Builds locally and the examples and tests pass.
Thank you @oleksandr-pavlyk for tracking down and resolving this
I have successfully run test suite on RTX 3050 for Laptops, Meteor Lake iGPU, and Core Ultra 7 CPU. The CI is also green, both internal and external. |
Closes gh-1901