Skip to content

Address CI warnings to not use nodefaults channel #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Remove use of nodefaults channel, use conda-remove-defaults: true instead

This change is prompted by CI warning:

'nodefaults' channel detected: will remove 'defaults' if added implicitly.
In the future, 'nodefaults' as a way of removing 'defaults' won't be
supported. Please set 'conda-remove-defaults' = 'true' to remove this warning.

image


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

…tead

This change is prompted by CI warning:

```
'nodefaults' channel detected: will remove 'defaults' if added implicitly.
In the future, 'nodefaults' as a way of removing 'defaults' won't be
supported. Please set 'conda-remove-defaults' = 'true' to remove this warning.
```
Copy link

github-actions bot commented Nov 18, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

ndgrigorian
ndgrigorian previously approved these changes Nov 18, 2024
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are gone, LGTM

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_220 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Nov 18, 2024

Coverage Status

coverage: 87.725%. remained the same
when pulling 60da3e7 on maint-conda-package-workflow-file
into 34ae129 on master.

@oleksandr-pavlyk
Copy link
Contributor Author

Deprecation warnings are gone. Future warnings are still present, but the log does not show defaults channel being active even though it may be temporarily added to the list of channels by conda.

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_240 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk, LGTM!

@ndgrigorian
Copy link
Collaborator

Unfortunately, the deprecated warnings appear to be back, for the Windows step

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread in my last comment, it was the future warnings. LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 9b3341a into master Nov 19, 2024
50 of 52 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the maint-conda-package-workflow-file branch November 19, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants