Skip to content

Delete remove defaults channel step from test_windows job #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2024
Merged

Delete remove defaults channel step from test_windows job #1886

merged 2 commits into from
Nov 7, 2024
+2 −5

Conversation

oleksandr-pavlyk
Copy link
Contributor

The setup-miniconda action is removing 'defaults' channels now, and attempt at repeated removal trips an error.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

antonwolfy
antonwolfy reviewed Nov 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_171 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2024 •
edited
Loading

Coverage Status

coverage: 87.686%. remained the same
when pulling 24dfea8 on fix-workflow-step-test-windows
into 7ffcca4 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_172 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

antonwolfy
antonwolfy approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ndgrigorian
ndgrigorian approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit 7782544 into master Nov 7, 2024
49 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-workflow-step-test-windows branch November 7, 2024 14:26
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleksandr-pavlyk @coveralls @ndgrigorian @antonwolfy