Improve dpctl.tensor.full error for invalid fill_value
#1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type pybind11 raises RuntimeError when a value cannot be cast to a type, i.e., a string to an integer. Now when scalar is not an array, a check is performed, and TypeError is raised
6 tasks
ndgrigorian
force-pushed
the
improve-full-error-for-invalid-scalar-type
branch
from
48faeac to
748fde5
Compare
|
I've added this change to the changelog as well. |
oleksandr-pavlyk
previously approved these changes
Oct 23, 2024
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_150 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_151 ran successfully. |
NumPy bools do not subclass `numbers.Number` and therefore must be handled separately. Python bools do, so no logic is needed.
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_152 ran successfully. |
oleksandr-pavlyk
approved these changes
Oct 23, 2024
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_158 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding a check to
fullwhen the value to construct the array with is not a scalar value, i.e., some type of object or a string.Previously these cases would fail, but pybind11 would throw RuntimeError. Now, a TypeError is thrown from Python, and the result array is never allocated, preventing wasted memory allocation.