Skip to content

Add missing #include <exception> #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add missing #include <exception> #1870

merged 1 commit into from
Oct 18, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Use of std::exception type (in catch(const std::exception &e) {), requires #include <exception>.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Add missing #include <exception>
3c0eac0 
Use of std::exception type (in `catch(const std::exception &e) {`),
requires `#include <exception>`.
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_137 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.669%. remained the same
when pulling 3c0eac0 on add-missing-include-exception
into 08605c4 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 85e4121 into master Oct 18, 2024
49 of 53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-missing-include-exception branch October 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian