Skip to content

Align recipe's meta yaml with conda-forge #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Oct 18, 2024

Install {{ stdlib('c') }} into build environment.

This requires adding conda_build_config.yaml where the version of the compiler as well as standard libraries be specified.

@ekomarova @xaleryb These changes break internal CI. Is there a way to align with conda-forge?

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Oct 18, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_147 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_148 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk changed the title Attempt to fix win ci Align recipe's meta yaml with conda-forge Nov 6, 2024
@ekomarova
Copy link
Contributor

Hi, @oleksandr-pavlyk! We have created a task for this SAT-7477. So far, I have come to the conclusion that the problem may be mamba render, but this requires further investigation

Base automatically changed from feature/radix-sort to master November 7, 2024 20:14
Copy link

github-actions bot commented Dec 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_296 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Dec 6, 2024

Coverage Status

coverage: 87.671%. remained the same
when pulling d6e8499 on fix-ci-win
into 5e35e0e on master.

@ekomarova
Copy link
Contributor

This is not working yet in internal CI because it is still not using docker with the new version of conda build, we're working on this

@AndresGuzman-Ballen
Copy link
Contributor

Alright, internal CI is using conda-build 3.28.4. Hopefully everything will now be smooth sailing for this PR :)

@ekomarova
Copy link
Contributor

ekomarova commented Dec 6, 2024

We need to remove sysroot_linux-64 as dependency for wheels. I'll create a PR

Copy link

github-actions bot commented Dec 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_297 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

Copy link

github-actions bot commented Dec 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_298 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@AndresGuzman-Ballen
Copy link
Contributor

Lots of green checkmarks! Yay!

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review December 7, 2024 18:28
@oleksandr-pavlyk oleksandr-pavlyk merged commit 45b0eff into master Dec 9, 2024
53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-ci-win branch December 9, 2024 15:25
antonwolfy added a commit to IntelPython/dpnp that referenced this pull request Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and
to revert changes from #1833.
Besides Windows 2019 GitHub image is going to be fully unsupported by
June 30, 2025.

The impacted workflows are moved to use "windows-2022" GH runners.
It requires updating `conda_build_config.yaml` where the version of the
compiler as well as standard libraries have to be specified.
While `{{ stdlib('c') }}` is installing into build environment as an
alignment with recipe's meta yaml from conda-forge (see
[dpctl#1868](IntelPython/dpctl#1868) as for
reference).
github-actions bot added a commit to IntelPython/dpnp that referenced this pull request Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and
to revert changes from #1833.
Besides Windows 2019 GitHub image is going to be fully unsupported by
June 30, 2025.

The impacted workflows are moved to use "windows-2022" GH runners.
It requires updating `conda_build_config.yaml` where the version of the
compiler as well as standard libraries have to be specified.
While `{{ stdlib('c') }}` is installing into build environment as an
alignment with recipe's meta yaml from conda-forge (see
[dpctl#1868](IntelPython/dpctl#1868) as for
reference). a4aa964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants