Lower the threshold to use sequential sort #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The threshold lowered from 64 elements to sort, to 16 elements. This recovers monotonicity of run-times curve. When number of array elements along the axis we sort is less than the threshold, a quadratic complexity insertion sort is used. Too high a value of the threshold (64) made for the artifact, where sorting 63 elements took several times longer than sorting 65 elements. Setting it to 16 recovers monotonicity (sorting 16 elements is not slower than sorting 17 elements).
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_134 ran successfully. |
ndgrigorian
reviewed
Oct 15, 2024
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_133 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_135 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threshold lowered from 64 elements to sort, to 16 elements. This recovers monotonicity of run-times curve.
When number of array elements along the axis we sort is less than the threshold, a quadratic complexity insertion sort is used. Too high a value of the threshold (64) made for the artifact, where sorting 63 elements took several times longer than sorting 65 elements.
Setting it to 16 recovers monotonicity (sorting 16 elements is not slower than sorting 17 elements).