Skip to content

Use Miniforge, use conda-forge channel #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Oct 7, 2024

The test_windows step of the workflow is currently broken with

  Downloading and Extracting Packages: ...working... done
  Preparing transaction: ...working... done
  Verifying transaction: ...working... done
  Executing transaction: ...working... done
  
  D:\a\dpctl\dpctl>L "C:\Users\runneradmin\miniconda3\condabin\..\Scripts\conda.exe"   install --name base "conda-build=*" 
  Warning: 'L' is not recognized as an internal or external command,
  operable program or batch file.
  
  'L' is not recognized as an internal or external command,
  operable program or batch file.
Error: The process 'C:\Users\runneradmin\miniconda3\condabin\conda.bat' failed with exit code 9009

Use miniforge and conda-forge channel only, to avoid mixing defaults and conda-forge.
Also fix steps to create sub-directories in the local channel.


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Oct 7, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Oct 7, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_109 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Oct 7, 2024

Coverage Status

coverage: 87.907%. remained the same
when pulling 05fade9 on fix-test-windows-step-in-conda-package-workflow
into f0f7837 on master.

@ndgrigorian
Copy link
Collaborator

@oleksandr-pavlyk
It seems to still fail with the same error message.

Copy link

github-actions bot commented Oct 7, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_110 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-test-windows-step-in-conda-package-workflow branch from f38663b to 0efa696 Compare October 7, 2024 18:50
Copy link

github-actions bot commented Oct 7, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_110 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

github-actions bot commented Oct 7, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_111 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

github-actions bot commented Oct 7, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_112 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-test-windows-step-in-conda-package-workflow branch from 1fdf9f2 to af01fb8 Compare October 8, 2024 00:17
Copy link

github-actions bot commented Oct 8, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_112 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

Copy link

github-actions bot commented Oct 8, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_113 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

github-actions bot commented Oct 8, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_114 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

github-actions bot commented Oct 8, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_115 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Remove auto-update-code from setup-miniconda step.
Create channel directory, then channel\win-64 directory.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-test-windows-step-in-conda-package-workflow branch from dfb243b to 05fade9 Compare October 8, 2024 15:50
@oleksandr-pavlyk oleksandr-pavlyk changed the title Use Miniforge, rather than broken Miniconda Use Miniforge, use conda-forge channel Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_109 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now working, LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit a03f7e9 into master Oct 8, 2024
49 of 53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-test-windows-step-in-conda-package-workflow branch October 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants