Skip to content

Throw exception in py_sort if inputs are not C-contiguous #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This changes behavior of py_sort C++ function to throw py::value_error exception should either input array be not C-contiguous.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Copy link
Collaborator

While you are in there, this comment can be removed too, since this is not reduction nor a special case.

Also deleted inaccurate comments.
@oleksandr-pavlyk
Copy link
Contributor Author

@ndgrigorian Done, and also applied the same change to argsort.cpp.

Copy link

github-actions bot commented Sep 16, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_42 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_43 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2024

Coverage Status

coverage: 87.907%. remained the same
when pulling 85d5cb9 on py-sorting-correction
into 5fc8c95 on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 45ce08b into master Sep 16, 2024
52 of 53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the py-sorting-correction branch September 16, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants