-
Notifications
You must be signed in to change notification settings - Fork 30
Propagate read-only flag from sycl_usm_array_interface in asarray #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate read-only flag from sycl_usm_array_interface in asarray #1756
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_161 ran successfully. |
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_167 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All dpnp tests pass with that change. And no more review comments from me.
Thank you @oleksandr-pavlyk
…es of the flag to improve coverage
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_168 ran successfully. |
Change to
dpt.asarray
to take read-only flag value from__sycl_usm_array_interface__
into account.