Skip to content

In pyproject change to numpy>=1.23 #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This is to align with current setup of public CI/CD.

Requirement "numpy >=1.24" was causing current build command which stipulates conda build ... -numpy 1.23 to use latest NumPy from Intel channel (which is 1.26), and resulted in produced artifact with metainformation requiring ">=1.26,<2.0a0".

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This is to align with current setup of public CI/CD.
Copy link

github-actions bot commented Jul 19, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_146 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2024

Coverage Status

coverage: 87.955%. remained the same
when pulling fceed47 on pyproject-numpy-lower-bound-1-23
into 0306b10 on master.

@oleksandr-pavlyk
Copy link
Contributor Author

Verified that the change accomplishes the intended affect:

(b_mkl_packages) opavlyk@opavlyk-mobl:~/repos/wd/dpctl_test$ conda search -c ./lc dpctl=0.18* --info
Loading channels: done
dpctl 0.18.0dev0 py311ha798474_146
----------------------------------
file name   : dpctl-0.18.0dev0-py311ha798474_146.tar.bz2
name        : dpctl
version     : 0.18.0dev0
build       : py311ha798474_146
build number: 146
size        : 21.5 MB
license     : Apache-2.0
subdir      : linux-64
url         : file:///home/opavlyk/repos/wd/dpctl_test/lc/linux-64/dpctl-0.18.0dev0-py311ha798474_146.tar.bz2
md5         : 27dafee6056d2cb5f716718d1708afac
timestamp   : 2024-07-19 17:23:27 UTC
dependencies:
  - __glibc >=2.28,<3.0.a0
  - dpcpp-cpp-rt >=2024.2,<2025.0a0
  - intel-cmplr-lib-rt >=2024.2,<2025.0a0
  - level-zero >=1.17,<2.0a0
  - level-zero >=1.17.19,<2.0a0
  - libgcc-ng >=14
  - libstdcxx-ng >=14
  - numpy >=1.23,<2.0a0
  - numpy >=1.23.5,<2.0a0
  - python >=3.11,<3.12.0a0

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review July 19, 2024 18:39
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_147 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 542c35f into master Jul 20, 2024
40 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the pyproject-numpy-lower-bound-1-23 branch July 20, 2024 13:40
@antonwolfy
Copy link
Collaborator

The pinning does not work properly for Windows still, requires numpy >=1.26,<2.0a0:

$ mamba search -i dpctl=0.18.0dev0=py311* --platform linux-64 -c dppy/label/dev --override-channels
Loading channels: done
dpctl 0.18.0dev0 py311ha798474_149
----------------------------------
file name   : dpctl-0.18.0dev0-py311ha798474_149.tar.bz2
name        : dpctl
version     : 0.18.0dev0
build       : py311ha798474_149
build number: 149
size        : 21.5 MB
license     : Apache-2.0
subdir      : linux-64
url         : https://conda.anaconda.org/dppy/label/dev/linux-64/dpctl-0.18.0dev0-py311ha798474_149.tar.bz2
md5         : 170d8f59022bbed2f8d205b935fceddd
timestamp   : 2024-07-20 14:14:39 UTC
dependencies:
  - __glibc >=2.28,<3.0.a0
  - dpcpp-cpp-rt >=2024.2,<2025.0a0
  - intel-cmplr-lib-rt >=2024.2,<2025.0a0
  - level-zero >=1.17,<2.0a0
  - level-zero >=1.17.19,<2.0a0
  - libgcc-ng >=14
  - libstdcxx-ng >=14
  - numpy >=1.23,<2.0a0
  - numpy >=1.23.5,<2.0a0
  - python >=3.11,<3.12.0a0

$ mamba search -i dpctl=0.18.0dev0=py311* --platform win-64 -c dppy/label/dev --override-channels
Loading channels: done
dpctl 0.18.0dev0 py311h82bb817_149
----------------------------------
file name   : dpctl-0.18.0dev0-py311h82bb817_149.tar.bz2
name        : dpctl
version     : 0.18.0dev0
build       : py311h82bb817_149
build number: 149
size        : 21.1 MB
license     : Apache-2.0
subdir      : win-64
url         : https://conda.anaconda.org/dppy/label/dev/win-64/dpctl-0.18.0dev0-py311h82bb817_149.tar.bz2
md5         : b902c482aa07b2024f6ed1313c75dbde
timestamp   : 2024-07-20 14:46:22 UTC
dependencies:
  - dpcpp-cpp-rt >=2024.2,<2025.0a0
  - intel-cmplr-lib-rt >=2024.2,<2025.0a0
  - level-zero >=1.17.19,<2.0a0
  - numpy >=1.26,<2.0a0
  - python >=3.11,<3.12.0a0
  - vc >=14.1,<15
  - vc14_runtime >=14.16.27033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants