Support DLPack on Windows #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since DPC++ 2024.2.0 implements support for default platform context on Windows, this enables proper support for DLPack exchange on Windows. Remove special case logic avoiding use of platform.default_context on Windows.
oleksandr-pavlyk
force-pushed
the
remove-dlpack-win-special-casing
branch
from
1c3598a to
3509c25
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_146 ran successfully. |
ndgrigorian
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DPC++ 2024.2.0 implements support for default platform context on Windows, this enables proper support for DLPack exchange on Windows.
Remove special case logic avoiding use of
platform.default_contexton Windows.Tests exist.