Skip to content

Fix for gh 1738 #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix for gh 1738 #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e6c9b6
Resolves gh-1738
oleksandr-pavlyk Jul 18, 2024
7e2c43c
Add test based on example provided in gh-1738
oleksandr-pavlyk Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dpctl/tensor/_set_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,7 @@ def unique_inverse(x):
)
_manager.add_event_pair(ht_ev, sub_ev)

inv_dt = dpt.int64 if x.size > dpt.iinfo(dpt.int32).max else dpt.int32
inv = dpt.empty_like(x, dtype=inv_dt, order="C")
inv = dpt.empty_like(x, dtype=ind_dt, order="C")
ht_ev, ssl_ev = _searchsorted_left(
hay=unique_vals,
needles=x,
Expand Down Expand Up @@ -608,8 +607,7 @@ def unique_all(x: dpt.usm_ndarray) -> UniqueAllResult:
)
_manager.add_event_pair(ht_ev, sub_ev)

inv_dt = dpt.int64 if x.size > dpt.iinfo(dpt.int32).max else dpt.int32
inv = dpt.empty_like(x, dtype=inv_dt, order="C")
inv = dpt.empty_like(x, dtype=ind_dt, order="C")
ht_ev, ssl_ev = _searchsorted_left(
hay=unique_vals,
needles=x,
Expand Down
22 changes: 22 additions & 0 deletions dpctl/tests/test_usm_ndarray_unique.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,3 +321,25 @@ def test_set_functions_compute_follows_data():
assert ind.sycl_queue == q
assert inv_ind.sycl_queue == q
assert uc.sycl_queue == q


def test_gh_1738():
get_queue_or_skip()

ones = dpt.ones(10, dtype="i8")
iota = dpt.arange(10, dtype="i8")

assert ones.device == iota.device

dpt_info = dpt.__array_namespace_info__()
ind_dt = dpt_info.default_dtypes(device=ones.device)["indexing"]

dt = dpt.unique_inverse(ones).inverse_indices.dtype
assert dt == ind_dt
dt = dpt.unique_all(ones).inverse_indices.dtype
assert dt == ind_dt

dt = dpt.unique_inverse(iota).inverse_indices.dtype
assert dt == ind_dt
dt = dpt.unique_all(iota).inverse_indices.dtype
assert dt == ind_dt
Loading