Skip to content

Use DPC++ 2024.1.0 to collect coverage #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Use DPC++ 2024.1.0 to collect coverage.

Use of 2023.2.0 was a work-around.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Mar 28, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.884% (-0.07%) from 87.952%
when pulling 1e80808 on collect-coverage-using-2024.1
into 54c98a3 on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_158 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@oleksandr-pavlyk
Copy link
Contributor Author

The change in coverage is due to CPU SYCL device in 2024.1.0 now supports float16 type, and so execution traverses different branches than in 2023.2.0

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage is working, branches no longer covered can have tests added in another PR

@oleksandr-pavlyk oleksandr-pavlyk merged commit 57495af into master Mar 28, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the collect-coverage-using-2024.1 branch March 28, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants