Fix main script #1614
Merged
Fix main script #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It outputed -lSyclInterface, which should be -lDPCTLSyclInterface Modified docstrings throughout to use correct library name
6 tasks
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_154 ran successfully. |
ndgrigorian
approved these changes
Mar 28, 2024
oleksandr-pavlyk
added a commit
that referenced
this pull request
Mar 28, 2024
Backport gh-1614 to 0.16.x maintenance branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of
python -m dpctl --libraryincorrectly output-lSyclInterface. It should have been-lDPCTLSyclInterface.This PR changes the output, adjusts docstrings to use correct library name and modifies test to assert that the expected library name occurs as a substring in the output.
This fix should be backported to 0.16.1