Skip to content

Fix generated -DNOTFOUND for compiling elementwise functions #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

E.g.

[123/222] $BUILD_PREFIX/bin/icpx -D_tensor_elementwise_impl_EXPORTS -DNOTFOUND -DUSE_SYCL_FOR_COMPLEX_TYPES \
     -I$BUILD_PREFIX/include \
     .... \
     -c $SRC_DIR/dpctl/tensor/libtensor/source/elementwise_functions/acos.cpp
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

E.g.

```
[123/222] $BUILD_PREFIX/bin/icpx -D_tensor_elementwise_impl_EXPORTS -DNOTFOUND -DUSE_SYCL_FOR_COMPLEX_TYPES \
     -I$BUILD_PREFIX/include \
     .... \
     -c $SRC_DIR/dpctl/tensor/libtensor/source/elementwise_functions/acos.cpp
```
Copy link

github-actions bot commented Jan 29, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.0%. remained the same
when pulling 5e539f9 on fix-DNOTFOUND-in-cmake-script
into 9b0a3cd on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_40 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

@oleksandr-pavlyk
Copy link
Contributor Author

From logs, the -DNOTFOUND is gone:

[152/222] $BUILD_PREFIX/bin/icpx -D_tensor_elementwise_impl_EXPORTS -DUSE_SYCL_FOR_COMPLEX_TYPES \
     -I$BUILD_PREFIX/include \
      .... \
      -c $SRC_DIR/dpctl/tensor/libtensor/source/elementwise_functions/floor_divide.cpp

@oleksandr-pavlyk oleksandr-pavlyk merged commit 86aaede into master Jan 29, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-DNOTFOUND-in-cmake-script branch January 29, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants