Skip to content

call operator of ProjFunctor must be const #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

Also changed the implementation of ProjFunctor to make compiler's job easier.

const is required for this struct to be usable in kernel if it is created on the host and passed to the kernel as parameter.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Also changed the implementation of ProjFunctor to make compiler's job eaiser.
@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_10 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

ndgrigorian
ndgrigorian previously approved these changes Sep 21, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 21, 2023

Coverage Status

coverage: 85.774%. remained the same when pulling b77720b on add-missing-const into 1f34c0d on master.

Tests to be disable are in test_sqrt, test_exp, test_trigonometric,
test_hyperbolic based on test run with 2024 compiler stack.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_12 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@ndgrigorian
Copy link
Collaborator

@oleksandr-pavlyk similar to my PR, you may want to update pyproject.toml again to reflect broken_complex skips on all platforms

"broken_complex: mark a test that is skipped on Windows due to complex implementation"

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_13 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CI is still red for some complex64 trig function tests, but we can add another PR to skip those.

This LGTM, thank you @oleksandr-pavlyk

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_15 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit b1c19fe into master Sep 22, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-missing-const branch September 22, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants