-
Notifications
You must be signed in to change notification settings - Fork 30
call operator of ProjFunctor must be const #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also changed the implementation of ProjFunctor to make compiler's job eaiser.
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1415/index.html |
Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_10 ran successfully. |
d7426a5
to
d88387b
Compare
Tests to be disable are in test_sqrt, test_exp, test_trigonometric, test_hyperbolic based on test run with 2024 compiler stack.
Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_12 ran successfully. |
@oleksandr-pavlyk similar to my PR, you may want to update
|
Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_13 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows CI is still red for some complex64 trig function tests, but we can add another PR to skip those.
This LGTM, thank you @oleksandr-pavlyk
Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_15 ran successfully. |
Also changed the implementation of ProjFunctor to make compiler's job easier.
const
is required for this struct to be usable in kernel if it is created on the host and passed to the kernel as parameter.