Skip to content

Use IntelSYCL cmake script #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 10, 2023
Merged

Use IntelSYCL cmake script #1400

merged 14 commits into from
Oct 10, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Replaced deprecated IntelDPCPPConfig.cmake vendored script with vendored IntelSYCLConfig.cmake.

Changed project's cmake scripts accordingly.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1400/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_3 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch 2 times, most recently from b59e877 to 42e43b9 Compare September 12, 2023 21:00
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_4 ran successfully.
Passed: 915
Failed: 85
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_4 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_4 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_5 ran successfully.
Passed: 915
Failed: 85
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 13, 2023 •
edited
Loading

Coverage Status

coverage: 85.68%. remained the same when pulling 550b20e on use-IntelSYCL-cmake-script into 08cc479 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_8 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_9 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from e740d55 to 2a52bdb Compare September 13, 2023 13:10
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_9 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from 63d404b to 6edff65 Compare September 22, 2023 13:01
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_11 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch 2 times, most recently from 5973fca to 6b9a6d6 Compare September 24, 2023 20:31
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_19 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from 6b9a6d6 to e857be6 Compare September 27, 2023 15:21
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_12 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from e857be6 to 7d45d5d Compare October 6, 2023 16:22
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_17 ran successfully.
Passed: 933
Failed: 67
Skipped: 119

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from aaa6512 to 97f5d3e Compare October 8, 2023 16:11
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch 3 times, most recently from 8fca0f9 to 293b15f Compare October 8, 2023 18:45
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review October 8, 2023 20:44
ndgrigorian
ndgrigorian previously approved these changes Oct 8, 2023
View reviewed changes
@oleksandr-pavlyk
Swap use of deprecated IntelDPCPP with IntelSYCL cmake script
a1b915a 
Removed cmake/IntelDPCPP.cmake, vendored cmake/IntelSYCL.cmake script

Changed project's CMake scripts to use IntelSYCL. Renamed
libsyclinterface/cmake/modules/FindIntelSycl.cmake to
libsyclinterface/cmake/modules/FindIntelSyclCompiler.cmake to
avoid possible name conflict on OS with case insensitive FS
@oleksandr-pavlyk
Use IntelSYCL instead of IntelDPCPP cmake script
5d5dcc2
@oleksandr-pavlyk
libsyclinterface/tests/test_helper.cpp needs SYCL
de644b9
@oleksandr-pavlyk
Make sure to not overwrite -fsycl option in select files
ce5e7c8 
Removed -fsycl for default linking options on Windows. The option
is added as needed.
@oleksandr-pavlyk
IntelSycl_VERSION -> IntelSyclCompiler_VERSION
5898fdd
@oleksandr-pavlyk
Added additional test file needed sycl
72e44ba
@oleksandr-pavlyk
Try to make link options add by add_sycl_to_target PRIVATE
679fdc9
@oleksandr-pavlyk
Do not override -fsycl
c6a9305
@oleksandr-pavlyk
Fixed typo in examples/pybind11/external_usm_allocation/CMakeLists.txt
5adfe0e
@oleksandr-pavlyk
Removed setting SKBUILD_LINK_LIBRARIES_KEYWORD since we move to cmake…
b60bc90 
…'s pyhon_add_library
@oleksandr-pavlyk
Use python_add_library with WITH_SOABI
ad1f120
@oleksandr-pavlyk
Set no-fast-math for reduction_over_axis too
9f078d9
@oleksandr-pavlyk
Channel OVERRIDE_INTEL_IPO env. variable
30b49b1 
Set variable in public CI to override using interprocedural optimization
in public CI to avoid insufficient resources failure during compilation
on Windows.
@oleksandr-pavlyk
_device_queries extension needs SYCL
550b20e
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-IntelSYCL-cmake-script branch from 939dbb8 to 550b20e Compare October 10, 2023 01:30
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_29 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 39e0700 into master Oct 10, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-IntelSYCL-cmake-script branch October 10, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian left review comments

@ZzEeKkAa ZzEeKkAa Awaiting requested review from ZzEeKkAa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian