Nonzero regression #1323
Merged
Nonzero regression #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes gh-1322 The indexes arrays must be allocated in default integral data type for the target device.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1323/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_80 ran successfully. |
antonwolfy
reviewed
Aug 2, 2023
There was a problem hiding this comment.
I've checked with full dpnp tests scope and it's successfully passing now. Thank you @oleksandr-pavlyk
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_80 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in output dtype of
tensor.nonzeroand closes gh-1322.Changes in gh-1300 made data type of indexes arrays was the same as dtype of temporary cumulative sum array, which incidentally worked before the change.