Test async changes #1298
Merged
Test async changes #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
force-pushed
the
test-async-changes
branch
from
bc4c227 to
adeac23
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1298/index.html |
oleksandr-pavlyk
force-pushed
the
test-async-changes
branch
2 times, most recently
from
a1437f3 to
3fc53d9
Compare
Few changes to reduce sporadic test failures.
1. Choose initial global work-size to be a multiple of
max_work_group_size to ensure that enough work is
being generated in the test
2. Retry submission if asyncronicity is not yet detected
and double the work if that does not help
oleksandr-pavlyk
force-pushed
the
test-async-changes
branch
from
3fc53d9 to
22694b5
Compare
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_18 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_18 ran successfully. |
vtavana
approved these changes
Jul 21, 2023
npolina4
approved these changes
Jul 21, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_22 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sycl_kernel_submit.py::test_async_submithas been sporadically failing as it attempts to confirm that concurrency was indeed detected. The chance of such detection decreases on beefier machines.This PR selects global-work-size for the submitted kernels based on device's max_work_group_size property, and increases it few times before failing the test.
This change should reduce the need to restart failing jobs just to get this test to pass.