Skip to content

skip numpy_usm_shared tests #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023
Merged

skip numpy_usm_shared tests #1259

merged 1 commit into from
Jun 22, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 21, 2023

With this PR, all tests for the numpy_usm_shared module are now skipped pending eventual removal.

This also fixes the coverage CI, which currently fails due to changes in Numpy 1.25.0 that break tests for the numpy_usm_shared module.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_8 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2023

Coverage Status

coverage: 83.244% (-0.9%) from 84.117% when pulling fd5c511 on numpy-1250-dparray-fix into 179ce15 on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review June 21, 2023 20:05
@diptorupd
Copy link
Contributor

@ndgrigorian The PR in itself is fine.

However, the numpy_usm_shared module is no longer used by numba_dpex and is no longer really needed. I have discussed it with @oleksandr-pavlyk and the plan is to remove the whole module and update associated documentation, tests and issues.

@ndgrigorian
Copy link
Collaborator Author

@ndgrigorian The PR in itself is fine.

However, the numpy_usm_shared module is no longer used by numba_dpex and is no longer really needed. I have discussed it with @oleksandr-pavlyk and the plan is to remove the whole module and update associated documentation, tests and issues.

In that case, I'll update this PR to mute the dparray tests instead.
The drive behind the PR was test failures leading to the the coverage CI not passing.

@ndgrigorian ndgrigorian force-pushed the numpy-1250-dparray-fix branch from 92a8f9c to fd5c511 Compare June 21, 2023 23:11
@ndgrigorian ndgrigorian changed the title numpy_usm_shared module updated for Numpy 1.25.0 skip numpy_usm_shared tests Jun 21, 2023
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_8 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday I investigated the issue with numpy_usm_shared module in due to the new numpy 1.25. But as @diptorupd said this module is not in use now and will be removed so it LGTM!

@ndgrigorian ndgrigorian merged commit d109770 into master Jun 22, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_8 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

@ndgrigorian ndgrigorian deleted the numpy-1250-dparray-fix branch August 8, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants