Skip to content

Use _depenv_s in libsyclinterface on Windows #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2023
Merged

Use _depenv_s in libsyclinterface on Windows #1255

merged 3 commits into from
Jun 26, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This RP refactors requested_verbosity_level function to solve #1246 and suggest the usage of _dupenv_s for Windows by conditional compilation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 19, 2023
@vlad-perevezentsev vlad-perevezentsev linked an issue Jun 19, 2023 that may be closed by this pull request
Deprecation warning when building libsyclinterface on Windows #1246
Closed
@vlad-perevezentsev vlad-perevezentsev marked this pull request as draft June 19, 2023 18:39
@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review June 20, 2023 15:37
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 83.246% (+0.002%) from 83.244% when pulling c1b19af on vlad-perevezentsev:replace_getenv into d109770 on IntelPython:master.

@vlad-perevezentsev vlad-perevezentsev merged commit 7c1d147 into IntelPython:master Jun 26, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the replace_getenv branch June 26, 2023 15:58
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_9 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning when building libsyclinterface on Windows
3 participants
@vlad-perevezentsev @coveralls @ndgrigorian