Skip to content

fix(Highlight): Check if the highlight group exists before activation. #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

gedinakova
Copy link
Contributor

Closes #15735

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@gedinakova gedinakova added ❌ status: awaiting-test PRs awaiting manual verification text-highlight labels Apr 29, 2025
@gedinakova gedinakova requested a review from igdmdimitrov April 29, 2025 08:18
@gedinakova gedinakova requested a review from teodosiah April 29, 2025 08:39
@gedinakova gedinakova changed the title test(Highlight): Adding a test for activating non-existent group. test(Highlight): Check if the highlight group exists before activation. Apr 29, 2025
@gedinakova gedinakova changed the title test(Highlight): Check if the highlight group exists before activation. fix(Highlight): Check if the highlight group exists before activation. Apr 29, 2025
@gedinakova gedinakova removed the ❌ status: awaiting-test PRs awaiting manual verification label May 2, 2025
@gedinakova gedinakova merged commit f72d834 into master May 2, 2025
5 checks passed
@gedinakova gedinakova deleted the gedinakova/fix-activate-highlight-15735 branch May 2, 2025 07:53
simeonoff pushed a commit that referenced this pull request May 13, 2025
#15762)

* test(Highlight): Adding a test for activating non-existent group.
* fix(Highlight): Adding a check for undefined before activation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxTextHighlightDirective is missing an undefined check
3 participants