-
Notifications
You must be signed in to change notification settings - Fork 160
ci(schematics): skipLibCheck on compile for schematics #13883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a5ba86
to
e4cba74
Compare
e4cba74
to
deba8fc
Compare
Correction on the description: What has changed though: /// <reference types="@types/node/url" />
/// <reference types="@types/node/ts4.8/url" /> Which causes this:
and then the build error:
Not exactly sure what the compile reason is for those references (I believe those are auto-emitted) and it might be a third-party issue to begin with. However, the default empty schematic project as provided by the Schematics CLI via |
(cherry picked from commit 1ece5cd)
Enable
skipLibCheck
for schematics compilation, becausenode_modules/@types/node
contains multiple versions and leads to the following problem. The solution was taken from: https://bobbyhadz.com/blog/typescript-duplicate-identifier#pulling-in-typings-from-multiple-versions-of-a-package.I've tried to update the @types/node package, but even with the latest, it contains multiple versions and the tsconfig setting is needed.
Anyway, all the types are updated along with the typescript package.Typescript was initially updated, along with @types, but we prefer to be automatically updated by a major/minor ng-update.The
build:schematics
script can be used for verification.