fix: test failed #85
Merged
fix: test failed #85
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himenon
commented
Oct 5, 2022
README.md
Outdated
| pnpm build && pnpm test | ||
| pnpm build | ||
| pnpm test:code:gen | ||
| pnpm test |
docs/ja/README-ja.md
Outdated
| #### your change | ||
| pnpm build | ||
| pnpm test:code:gen | ||
| pnpm test |
Himenon
force-pushed
the
fix/test-failed
branch
from
551f808 to
cba768c
Compare
Himenon
commented
Oct 5, 2022
| @@ -11,14 +11,16 @@ import { shell } from "./tools/shell"; | |||
| const generateVersionTsFile = () => { | |||
| const codes: string[] = [`export const Name = "${pkg.name}";`, `export const Version = "${pkg.version}";`]; | |||
| const tscCode = codes.join(EOL); | |||
| if (process.env.CI) { | |||
There was a problem hiding this comment.
Remove CI Flag. Developer can always reproduce test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #84
Test Plan