Skip to content

feat: add readonly flag #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 17, 2023
Merged

feat: add readonly flag #82

merged 6 commits into from
May 17, 2023

Conversation

Himenon
Copy link
Owner

@Himenon Himenon commented Jun 21, 2022

Summary

https://swagger.io/specification/

Test Plan

schema:
  type: object
  properties:
    name:
      type: string
      readOnly: true

@Himenon
Copy link
Owner Author

Himenon commented Jun 21, 2022

thinking ....

@Himenon Himenon marked this pull request as draft June 21, 2022 02:18
@Himenon Himenon closed this May 12, 2023
@miyakojin
Copy link

こちらがmergeされるのを期待していたのですが今後はreadOnlyには対応しない方針ですか?

@Himenon
Copy link
Owner Author

Himenon commented May 17, 2023

おぉ、需要がないものと思いcloseしてしまいました。

@Himenon Himenon reopened this May 17, 2023
@Himenon Himenon marked this pull request as ready for review May 17, 2023 12:22
@Himenon Himenon merged commit 01922e3 into main May 17, 2023
@Himenon Himenon deleted the feat/readonly branch May 17, 2023 12:25
@miyakojin
Copy link

おぉ、ご対応ありがとうございます。
感謝です〜。

@Himenon
Copy link
Owner Author

Himenon commented May 18, 2023

バグが有りましたら、issueなどに起票をお願いします!

@miyakojin
Copy link

本来なら、issueでコメントするところをPRコメントで汚してしまい申し訳ないです。
古いバージョンを使わせて頂いてて、typescriptのバージョンアップがすぐには難しく試せるようになるまで時間がかかると思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants