Skip to content

fix: Trim the trailing slash of baesUrl #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix: Trim the trailing slash of baesUrl #55

merged 1 commit into from
Aug 11, 2021

Conversation

Himenon
Copy link
Owner

@Himenon Himenon commented Aug 11, 2021

Summary

Invalid code

let baseUrl = "https://api.example.com/"

....
baseUrl + "/a/b/c";
# => https://api.example.com//a/b/c

Code that works reliably

let baseUrl = "https://api.example.com/"

....
baseUrl.replace(/\/$/, "") + "/a/b/c";
# => https://api.example.com/a/b/c

Test Plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant