Skip to content

provide incomplete tags / function completion for Twig #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import com.intellij.codeInsight.lookup.LookupElementBuilder;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Pair;
import com.intellij.patterns.PlatformPatterns;
import com.intellij.patterns.*;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.psi.PsiWhiteSpace;
Expand Down Expand Up @@ -406,6 +406,45 @@ public void addCompletions(@NotNull CompletionParameters parameters, ProcessingC
}
}
);

// {% e => {% extends '...'
extend(
CompletionType.BASIC,
PlatformPatterns.psiElement(TwigTokenTypes.TAG_NAME).withSuperParent(2, PsiFile.class),
new IncompleteExtendsCompletionProvider()
);

// {% in => {% include '...'
extend(
CompletionType.BASIC,
PlatformPatterns.psiElement(TwigTokenTypes.TAG_NAME),
new IncompleteIncludeCompletionProvider()
);

// {{ in => {{ include('...')
extend(
CompletionType.BASIC,
TwigPattern.getCompletablePattern(),
new IncompleteIncludePrintBlockCompletionProvider()
);
}

private boolean isCompletionStartingMatch(@NotNull String fullText, @NotNull CompletionParameters completionParameters, int minLength) {
PsiElement originalPosition = completionParameters.getOriginalPosition();
if (originalPosition != null) {
String text = originalPosition.getText();
if (text.length() >= minLength && fullText.startsWith(text)) {
return true;
}
}

PsiElement position = completionParameters.getPosition();
String text = position.getText().toLowerCase().replace("intellijidearulezzz", "");
if (text.length() >= minLength && fullText.startsWith(text)) {
return true;
}

return false;
}

private static class FilterCompletionProvider extends CompletionProvider<CompletionParameters> {
Expand Down Expand Up @@ -664,5 +703,103 @@ protected void addCompletions(@NotNull CompletionParameters parameters, Processi
);
}
}

/**
* {% e => {% extends '...'
*/
private class IncompleteExtendsCompletionProvider extends CompletionProvider<CompletionParameters> {
@Override
protected void addCompletions(@NotNull CompletionParameters completionParameters, @NotNull ProcessingContext processingContext, @NotNull CompletionResultSet resultSet) {
if(!Symfony2ProjectComponent.isEnabled(completionParameters.getPosition())) {
return;
}

if (!isCompletionStartingMatch("extends", completionParameters, 1)) {
return;
}

List<String> extendsTemplateUsageAsOrderedList = TwigUtil.getExtendsTemplateUsageAsOrderedList(completionParameters.getPosition().getProject(), 50);

CompletionSorter completionSorter = CompletionService.getCompletionService()
.defaultSorter(completionParameters, resultSet.getPrefixMatcher())
.weigh(new ServiceCompletionProvider.MyLookupElementWeigher(extendsTemplateUsageAsOrderedList));

resultSet = resultSet.withRelevanceSorter(completionSorter);

for (String s : extendsTemplateUsageAsOrderedList) {
resultSet.addElement(LookupElementBuilder.create(String.format("extends '%s'", s)).withIcon(TwigIcons.TwigFileIcon));
}
}
}

/**
* {% in => {% include '...'
*/
private class IncompleteIncludeCompletionProvider extends CompletionProvider<CompletionParameters> {
@Override
protected void addCompletions(@NotNull CompletionParameters completionParameters, @NotNull ProcessingContext processingContext, @NotNull CompletionResultSet resultSet) {
if(!Symfony2ProjectComponent.isEnabled(completionParameters.getPosition())) {
return;
}

resultSet.restartCompletionOnPrefixChange(StandardPatterns.string().longerThan(1).with(new PatternCondition<>("include startsWith") {
@Override
public boolean accepts(@NotNull String s, ProcessingContext processingContext) {
return "include".startsWith(s);
}
}));

if (!isCompletionStartingMatch("include", completionParameters, 2)) {
return;
}

List<String> extendsTemplateUsageAsOrderedList = TwigUtil.getIncludeTemplateUsageAsOrderedList(completionParameters.getPosition().getProject(), 50);

CompletionSorter completionSorter = CompletionService.getCompletionService()
.defaultSorter(completionParameters, resultSet.getPrefixMatcher())
.weigh(new ServiceCompletionProvider.MyLookupElementWeigher(extendsTemplateUsageAsOrderedList));

resultSet = resultSet.withRelevanceSorter(completionSorter);

for (String s : extendsTemplateUsageAsOrderedList) {
resultSet.addElement(LookupElementBuilder.create(String.format("include '%s'", s)).withIcon(TwigIcons.TwigFileIcon));
}
}
}

/**
* {{ in => {{ include('...')
*/
private class IncompleteIncludePrintBlockCompletionProvider extends CompletionProvider<CompletionParameters> {
@Override
protected void addCompletions(@NotNull CompletionParameters completionParameters, @NotNull ProcessingContext processingContext, @NotNull CompletionResultSet resultSet) {
if(!Symfony2ProjectComponent.isEnabled(completionParameters.getPosition())) {
return;
}

resultSet.restartCompletionOnPrefixChange(StandardPatterns.string().longerThan(1).with(new PatternCondition<>("include startsWith") {
@Override
public boolean accepts(@NotNull String s, ProcessingContext processingContext) {
return "include".startsWith(s);
}
}));

if (!isCompletionStartingMatch("include", completionParameters, 2)) {
return;
}

List<String> extendsTemplateUsageAsOrderedList = TwigUtil.getIncludeTemplateUsageAsOrderedList(completionParameters.getPosition().getProject(), 50);

CompletionSorter completionSorter = CompletionService.getCompletionService()
.defaultSorter(completionParameters, resultSet.getPrefixMatcher())
.weigh(new ServiceCompletionProvider.MyLookupElementWeigher(extendsTemplateUsageAsOrderedList));

resultSet = resultSet.withRelevanceSorter(completionSorter);

for (String s : extendsTemplateUsageAsOrderedList) {
resultSet.addElement(LookupElementBuilder.create(String.format("include('%s')", s)).withIcon(TwigIcons.TwigFileIcon));
}
}
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.intellij.codeInsight.completion.*;
import com.intellij.codeInsight.lookup.LookupElement;
import com.intellij.codeInsight.lookup.LookupElementBuilder;
import com.intellij.patterns.ElementPattern;
import com.intellij.patterns.PlatformPatterns;
import com.intellij.psi.PsiElement;
Expand Down