PhpStorm 2020.3: Code that doesn't expect named arguments usages

[wbars]

Here are code pieces that we found that may work not correctly with named arguments:

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/assistant/signature/MethodSignatureTypeProvider.java

  Line 65 in 995fa6e

  PsiElement[] parameters = ((MethodReference)e).getParameters();

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/codeInspection/form/FormTypeAsClassConstantInspection.java

  Line 61 in 147d6d0

  if(!(parameters[1] instanceof StringLiteralExpression) || ((StringLiteralExpression) parameters[1]).getContents().contains("\\")) {

• All usages of fr.adrienbrault.idea.symfony2plugin.completion.command.PhpCommandGotoCompletionRegistrar.CommandGotoCompletionProvider#getParameterStringValue

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/config/utils/ConfigUtil.java

  Line 130 in 6826000

  String contents = PhpElementsUtil.getStringValue(parameters[0]);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/container/util/ServiceContainerUtil.java

  Line 329 in 133d25e

  serviceName = getStringValueIndexSafe(parameters[0]);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/querybuilder/QueryBuilderCompletionContributor.java

  Line 400 in 147d6d0

  String repoName = PhpElementsUtil.getStringValue(methodReference.getParameters()[0]);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/querybuilder/QueryBuilderMethodReferenceParser.java

  Line 275 in d2fc370

  PsiElement parameter = parameters[1];

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/form/util/FormOptionsUtil.java

  Line 298 in 3ff1023

  if(parameters.length > 0 && parameters[0] instanceof ArrayCreationExpression) {

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/form/util/FormOptionsUtil.java

  Line 317 in 3ff1023

  if(parameters[0] instanceof ArrayCreationExpression) {

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/PhpMethodVariableResolveUtil.java

  Line 312 in 793219d

  if (parameters[0] instanceof StringLiteralExpression) {

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java

  Line 326 in 4dfa283

  String funcName = PhpElementsUtil.getStringValue(psiElement[0]);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java

  Line 457 in 4dfa283

  signature = getCallableSignature(psiElement[1], method);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java

  Line 559 in 4dfa283

  if(psiElement.length > 1 && psiElement[1] instanceof StringLiteralExpression) {

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/translation/TranslationPlaceholderGotoCompletionRegistrar.java

  Line 124 in 76cfade

  domain = PhpElementsUtil.getStringValue(parameters[domainParameter]);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/translation/parser/TranslationPsiParser.java

  Line 97 in d008eea

  Collection<ArrayHashElement> domainArrays = PsiTreeUtil.getChildrenOfTypeAsList(parameters[1], ArrayHashElement.class);

• idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/util/EventDispatcherTypeProvider.java

  Line 54 in 995fa6e

  ClassReference classReference = ((NewExpression) parameters[1]).getClassReference();

Generally now it's necessary to take named arguments into account to provide correct behaviour for PHP 8. In 203 build we do have some methods for this to ease the migration. If index is accessible it's recommended to use com.jetbrains.php.PhpWorkaroundUtil#resolveMappedParameterIndex(com.intellij.psi.PsiElement), this method will resolve parameter index taking into account both named argument part and position.

references: https://jetbrains.org/intellij/sdk/docs/products/phpstorm/php_open_api_breaking_changes_203.html