Skip to content

Fix documentation of zlib-rs feature: no longer conflicts with other zlibs #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

joshtriplett
Copy link
Contributor

@joshtriplett joshtriplett commented Apr 20, 2025

As of zlib-rs 0.5.0 (depended on by flate2 1.1.1, which all dependency versions in gitoxide already specify as a minimum), zlib-rs no longer exports C symbols by default, so it doesn't conflict with any other zlib that might be loaded into the address space. Update the documentation accordingly.

@joshtriplett joshtriplett marked this pull request as ready for review April 20, 2025 15:18
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help!

zlib-rs is an incredible achievement and I love to see it spread.

@Byron Byron merged commit f3684a4 into GitoxideLabs:main Apr 20, 2025
22 checks passed
@joshtriplett joshtriplett deleted the zlib-rs branch April 20, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants