gix-blame
: Replace BTreeMap
by SmallVec
#1945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases
gix-blame
’s performance by replacingsuspects: BTreeMap
withsuspects: SmallVec
.A
SmallVec
provides a better trade-off with respect to performance than aBTreeMap
becausesuspects
in most cases only contains 1 item. The cost of callingBTreeMap::insert
andBTreeMap::remove
becomes noticeable in profiling the longer a blame’s history gets and the more hunks a file is split into.For smaller blames, the benefits are negligible, but for larger repos and larger files they are so significant that I’m worried I might have made a mistake trying to measure them. 😄
The following benchmarks compare this PR against
main
.