handle many packs better #1750
Merged
handle many packs better #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
odb-issue
branch
3 times, most recently
from
34197e7 to
56a1e8f
Compare
…an hold. Internally, there is a statically allocated vec which holds opened packs and indices. When reconciling the disk-state with what's currently loaded, it was possible to get into a situation where there were more files than we could fit into the slotmap and got into an invalid state. The system now generously trashes existing slots to be able to load more rencent ones, which seems to help in this situation. It's probably still leading to strange situations where not all objects can be read.
Byron
force-pushed
the
odb-issue
branch
2 times, most recently
from
5a9384b to
7f4e571
Compare
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Apr 2, 2025
Summary: Similar to D66758489. Upgrade `gix` libraries. I'd like to try `gix-odb` (to replace libgit2) in sapling. I read its recent changelog and GitoxideLabs/gitoxide#1750 looks concerning. So I'd like to upgrade `gix-odb` first to include the fix, before switching. Reviewed By: RajivTS Differential Revision: D72286005 fbshipit-source-id: 9ca247f3c384c4fb19e0d1944013305b9f76f01c
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Apr 2, 2025
Summary: Similar to D66758489. Upgrade `gix` libraries. I'd like to try `gix-odb` (to replace libgit2) in sapling. I read its recent changelog and GitoxideLabs/gitoxide#1750 looks concerning. So I'd like to upgrade `gix-odb` first to include the fix, before switching. Reviewed By: RajivTS Differential Revision: D72286005 fbshipit-source-id: 9ca247f3c384c4fb19e0d1944013305b9f76f01c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the issue originally reported here: frewsxcv/rust-crates-index#181.
At least past of the problem is that there are more and more packs accumulating, and eventually the pack-map is full.
This leads to objects not being found anymore (outside of any possible race conditions).
Tasks
Object de01e95cf873164afae15e080903b6a7b22d6329 as referred to by "refs/remotes/origin/master" could not be found/gix-odb-0.66.0/src/store_impls/dynamic/load_index.rs:374:13: if the generation changed, the slot index must have changed for sure