-
-
Notifications
You must be signed in to change notification settings - Fork 354
Allow construct CustomFormat outside the crate #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c3d04fa
to
4910912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Note that I adjusted the commit-message so this becomes a feature to be added to the changelog.
One question is that shall we use
Cow<'static, str>
instead to allow define a non-static format?
It's probably something for another time once there is demand. That would require dynamic formats to be used, which probably is quite rare.
@Byron Thank you! I checked the logs and didn't find a consistent pattern on messages: Some follow the conventional commits flavor and others follow a capital message. From your comment it seems conventional commits should be used consistently, if so I'll apply it for the potential following contributions :D |
Yeah. So let's avoid to be too generic too early :D |
Actually that's not the case. They are only used if something should go into the changelog, and to signal breaking changes as well. That's why it's not always used, just sometimes. |
OK. Besides, I'm using this crate with |
Usually on the 22nd of each month there is a new release. |
Looks like I'm lucky 😆 |
@Byron One question is that shall we use
Cow<'static, str>
instead to allow define a non-static format?It breaks the
Copy
trait somehow so I don't make this change. And a static format is sufficient for my use cases.