Improve comments in a couple private functions #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mention `/Applications` as well as `/Library`, since macOS users with a full Xcode installation installation seem often to have Apple Git under `/Applications` rather than under `/Library`, but this higher-than-system "unknown" scope applies equally to both. - Expand the explanation enough to make clear what the conceptual relationship is between `GIT_CONFIG_SYSTEM` and `--system` and why the disparity between the scopes they select could be misleading in a relevant way.
Byron
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR has some comment edits that I would ideally have included in previous PRs but didn't notice the need for at the time, and that don't seem like they are particularly suited to any other PRs I would likely make in the next couple days. So I'm opening this for them.