Skip to content

Wrong entry order in tree object #848

Closed
@SilkovAlexander

Description

@SilkovAlexander

Duplicates

  • I have searched the existing issues

Current behavior 😯

Current implementation sorts the tree entries alphabetically without looking at the entry type, but git (at least on Ubuntu) sorts it in a slightly different manner. Git virtually "adds" '/' to tree filenames.
git sorted list of entries:

100644 blob a7f8d9e5dcf3a68fdd2bfb727cde12029875260b    bin
100644 blob 257cc5642cb1a054f08cc83f2d943e56fd3ebe99    bin.d
100644 blob 6c493ff740f9380390d5c9ddef4af18697ac9375    file.to
100644 blob e2129701f1a4d54dc44f03c93bca0a2aec7c5449    file.toml
100644 blob 7c8ac2f8d82a1eb5f6aaece6629ff11015f91eb4    file.toml.bin
040000 tree 66ad2859083f44f0a1504dc91c15c9b754372c01    file
100644 blob 8d80099b0791274e24014d8dc299d4d2f3c2054d    file0

and this implementation rakes into account only filenames.

Expected behavior 🤔

I'd expect this code of Ord trait implementation for Entry add '/' symbol to tree filenames for comparing/

Steps to reproduce 🕹

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions