Skip to content

Fix false boolean query string encoding #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2017
Merged

Fix false boolean query string encoding #237

merged 1 commit into from
Aug 26, 2017

Conversation

fbourigault
Copy link
Contributor

The QueryStringBuilder has a bug with encoding the false value.

See https://3v4l.org/r4Sqt for the http_build_query behavior.

@fbourigault fbourigault requested a review from m1guelpf August 25, 2017 12:45
@fbourigault
Copy link
Contributor Author

Thank you for the review!

@fbourigault fbourigault merged commit af99282 into GitLabPHP:master Aug 26, 2017
@fbourigault fbourigault deleted the query-string-boolean-encoding branch August 26, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1guelpf m1guelpf m1guelpf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbourigault @m1guelpf