This repository was archived by the owner on Feb 8, 2023. It is now read-only.
Fix to work with custom $interpolationProvider #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded interpolate symbols and replace with dynamic ones.
Without stringifying the injected provider, we'd lose it in the minification process.
I didn't know what minification process was used previously. Went with closure compiler to do this.
|
Thanks. I merged other commits so the minified file will don't contain all of them. I will fix it later with the new release. |
GabrielDelepine
pushed a commit
that referenced
this pull request
Dec 18, 2014
Fix to work with custom $interpolationProvider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue found here: #18
Simply replaced the hard-coded interpolation symbols {{ and }} with the dynamic $interpolationProvider.startSymbol() and $interpolationProvider.endSymbol().
I updated minified version of library, but it's probably not ideal. I was unsure what was previously used.
ebn