Skip to content

[PR] Fix typos in exercise/queries #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2019
Merged

[PR] Fix typos in exercise/queries #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bce58a
Fix typos in exercise/queries
Feb 13, 2019
ac7bdd7
Fix typo in queries.spec.js
Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions exercises/queries/__test__/queries.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const {
const Post = require('../post')
const Author = require('../author')
const mongoose = require('mongoose')
const createConent = (length, fill = 'b') => new Array(length).fill(fill).join('')
const createContent = (length, fill = 'b') => new Array(length).fill(fill).join('')

describe('queries', () => {
describe('postByTitle', () => {
Expand All @@ -18,7 +18,7 @@ describe('queries', () => {
const post = await Post.create({
title,
author: mongoose.Types.ObjectId(),
content: createConent(50),
content: createContent(50),
contentLength: 50
})

Expand All @@ -33,7 +33,7 @@ describe('queries', () => {
const post = await Post.create({
author,
title: 'Carter v',
content: createConent(50),
content: createContent(50),
contentLength: 50
})
const [match] = await postsForAuthor(author)
Expand All @@ -46,9 +46,9 @@ describe('queries', () => {
const author = mongoose.Types.ObjectId()

const posts = await Post.create([
{title: 'Super Duper', author, content: createConent(1000), contentLength: 1000},
{title: 'Amazing', author, content: createConent(100), contentLength: 100},
{title: 'Other', author, content: createConent(800), contentLength: 800}
{title: 'Super Duper', author, content: createContent(1000), contentLength: 1000},
{title: 'Amazing', author, content: createContent(100), contentLength: 100},
{title: 'Other', author, content: createContent(800), contentLength: 800}
])

const matches = await postByContentLength(1000, 100)
Expand All @@ -64,15 +64,15 @@ describe('queries', () => {
const post = await Post.create({
title: 'Super Duper',
author: author.id,
content: createConent(1000),
content: createContent(1000),
contentLength: 1000
})
const post2 = await Post.create({
author: author.id,
title: 'Post 2',
content: createConent(100),
content: createContent(100),
contentLength: 100,
simularPosts: [post.id]
similarPosts: [post.id]
})

const match = await fullPostById(post2.id)
Expand All @@ -83,9 +83,9 @@ describe('queries', () => {
test('only selects fields given', async () => {
const author = mongoose.Types.ObjectId()
await Post.create([
{title: 'learn things', content: createConent(100), contentLength: 100, author},
{title: 'lean more things', content: createConent(100), contentLength: 100, author},
{title: 'lean more things++', content: createConent(100), contentLength: 100, author}
{title: 'learn things', content: createContent(100), contentLength: 100, author},
{title: 'lean more things', content: createContent(100), contentLength: 100, author},
{title: 'lean more things++', content: createContent(100), contentLength: 100, author}
])

const matches = await allPostsSlim({title: 1, content: 1})
Expand All @@ -98,12 +98,12 @@ describe('queries', () => {
})
})
describe('addRelatedPosts', () => {
test('should not overrided related posts that are there', async () => {
test('should not override related posts that are there', async () => {
const author = mongoose.Types.ObjectId()
const post = await Post.create({
author,
title: 'Post',
content: createConent(100),
content: createContent(100),
contentLength: 100,
similarPosts: [mongoose.Types.ObjectId()]
})
Expand Down
2 changes: 1 addition & 1 deletion exercises/queries/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const postSchema = new mongoose.Schema({
},
isFeatured: {
type: Boolean,
deafult: false
default: false
},
similarPosts: [{
type: mongoose.Schema.Types.ObjectId,
Expand Down