Skip to content

Provide an option to not verify the domain #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2013

Conversation

craigtracey
Copy link
Contributor

Domains are not always easily specified. With things like GitHub
Enterprise and other "non-standard" domains, this parsing method
will short-circuit.

Therefore provide a mechanism to disable domain verification.

Domains are not always easily specified. With things like GitHub
Enterprise and other "non-standard" domains, this parsing method
will short-circuit.

Therefore provide a mechanism to disable domain verification.
@AaronO
Copy link
Contributor

AaronO commented Dec 29, 2013

@craigtracey Hey thanks for providing this. I haven't used this for any private installs, but it definitely makes sense.

I'm sorry to be nitpicky one little thing. Could you revert back your commits, to remove your version bump ?

Simply do :

git reset --hard HEAD~1
git push --force

It's mostly because I follow the standard of naming bump commits as Bump version to x.y.z (which allows you to easily see versions when looking at the history).

So once you've done that I'll merge your pull request, bump, tag and push to PyPi.

Sorry for being nitpicky and thanks for the PR :)

@craigtracey
Copy link
Contributor Author

@AaronO yeah, no problem. And, not nitpicky.

I have reset head and, frankly, the only reason I had that was to ensure that I was pulling in the proper dependency. It'll be nice to install from PyPi (over my github fork), so yeah...all for that!

AaronO added a commit that referenced this pull request Dec 29, 2013
Provide an option to not verify the domain
@AaronO AaronO merged commit a471f47 into FriendCode:master Dec 29, 2013
@AaronO
Copy link
Contributor

AaronO commented Dec 29, 2013

@craigtracey Thanks 👍

@AaronO
Copy link
Contributor

AaronO commented Dec 29, 2013

@craigtracey Bumped, taged and pushed to PyPi (https://pypi.python.org/pypi/giturlparse.py)

@craigtracey
Copy link
Contributor Author

@AaronO thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants