Skip to content

add support for Gogs repository #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slarosa
Copy link

@slarosa slarosa commented Nov 3, 2017

No description provided.

@strk
Copy link

strk commented Nov 5, 2017

NOTE: Gogs (and Gitea) can also be installed in a subdirectory, so the url may look like: https://<domain>/<installpath>/<org>/<repo>

I dunno how giturlparse would deal with such URIs (it is server-configuration dependant)

@slarosa
Copy link
Author

slarosa commented Nov 5, 2017

I guess that we can add different patterns and formats more later, even if I think that <installpath> is part of host. So all is good here, for the moment. Waiting for testing!

@gene1wood
Copy link

@slarosa It looks like this repo hasn't been updated in about 3 years. @yakky has a fork called githubparse that has implemented a number of the PRs that are pending here on giturlparse.py and has activity from last year.

You might want to switch to his fork and propose your Gogs PR there.

@yakky
Copy link
Contributor

yakky commented Jan 20, 2018

Thanks @gene1wood
I am available to review this on my fork https://github.com/yakky/giturlparse

@slarosa
Copy link
Author

slarosa commented Feb 13, 2018

thanks @gene1wood, I will do a PR on @yakky's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants