Skip to content

Automatically download embeddings #13

Open
@stefan-it

Description

@stefan-it

Hi,

thanks creating this text classification benchmark!

I wanted to run the basic example python3 main.py --model cnn and I could see that the GloVe embeddings were not downloaded automatically.

The dataHelper.loadData(opt) never calls the Glove constructor, so the embeddings won't be downloaded. But when I change from_torchtext = False to from_torchtext = True the utils.loadData(opt) method calls the Glove constructor.

I guess calling the Glove constructor would be enough to call it before the glove_file declaration (from here)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions