-
Notifications
You must be signed in to change notification settings - Fork 268
Added missing MidiControlChangeNumber definitions #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are some errors, you've got duplicate names in the enum: |
@franky47 Fixed |
Great, thanks! Could you add those new definitions to keywords.txt, so that they are syntax highlighted please ? |
@franky47 keywords added |
Thank you! |
@franky47 what's the process for getting the new version of the library out to PlatformIO? |
You should be able to use a GitHub link as your dependency to point to the master branch which includes your PR: |
@franky47 cool, I'll use that for now. Are you able to tag the latest as Is there anything I can help with to publish a new version of the library to PlatformIO? |
I usually try to batch several features/bugfixes into a release, these days I don't have a lot of time to do some archeology over what happened in the last two years since the last release, but I agree that an update is in order. I'll keep you posted. |
You could use a direct commit hash as an immutable reference to your PR in master: |
To address #259
Based on definitions from https://www.recordingblogs.com/wiki/midi-controller-message