Skip to content

Added missing MidiControlChangeNumber definitions #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

muxa
Copy link
Contributor

@muxa muxa commented Nov 28, 2021

@franky47
Copy link
Member

There are some errors, you've got duplicate names in the enum:
https://github.com/FortySevenEffects/arduino_midi_library/runs/4347255153?check_suite_focus=true

@muxa
Copy link
Contributor Author

muxa commented Nov 29, 2021

@franky47 Fixed

@coveralls
Copy link

coveralls commented Nov 29, 2021

Coverage Status

Coverage remained the same at 99.625% when pulling 9edd85f on muxa:more-defs into 1944aca on FortySevenEffects:master.

@franky47
Copy link
Member

Great, thanks! Could you add those new definitions to keywords.txt, so that they are syntax highlighted please ?

@muxa
Copy link
Contributor Author

muxa commented Nov 29, 2021

@franky47 keywords added

@franky47 franky47 merged commit 8e9805f into FortySevenEffects:master Nov 29, 2021
@franky47
Copy link
Member

Thank you!

@muxa muxa deleted the more-defs branch November 29, 2021 20:09
@muxa
Copy link
Contributor Author

muxa commented Nov 29, 2021

@franky47 what's the process for getting the new version of the library out to PlatformIO?

@franky47
Copy link
Member

franky47 commented Nov 29, 2021

You should be able to use a GitHub link as your dependency to point to the master branch which includes your PR:
https://docs.platformio.org/en/latest/core/userguide/lib/cmd_install.html#git

@muxa
Copy link
Contributor Author

muxa commented Nov 29, 2021

@franky47 cool, I'll use that for now. Are you able to tag the latest as 5.0.3 so I can reference a specific version?

Is there anything I can help with to publish a new version of the library to PlatformIO?

@franky47
Copy link
Member

franky47 commented Nov 29, 2021

I usually try to batch several features/bugfixes into a release, these days I don't have a lot of time to do some archeology over what happened in the last two years since the last release, but I agree that an update is in order. I'll keep you posted.

@franky47
Copy link
Member

You could use a direct commit hash as an immutable reference to your PR in master:
https://github.com/FortySevenEffects/arduino_midi_library.git#8e9805fc926f3b116df4579ff0b0b72bc0c97ec7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants