Skip to content

updated send(midiMessage&) to better handle system real time, #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2021
Merged

updated send(midiMessage&) to better handle system real time, #250

merged 2 commits into from
Nov 3, 2021

Conversation

paul-emile-element
Copy link
Contributor

sysex and other system common messages

updated send(midiMessage&) to better handle system real time,
299cd97 
sysex and other system common messages
@paul-emile-element paul-emile-element mentioned this pull request Nov 2, 2021
Open
@coveralls
Copy link

coveralls commented Nov 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 99.625% when pulling 8c39aea on paul-emile-element:pe-send-159 into be557c1 on FortySevenEffects:master.

franky47
franky47 requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@franky47 franky47 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the message method names.

I like the masking trick to tell apart channel, real time and common, great job!

@franky47 franky47 merged commit 663b24b into FortySevenEffects:master Nov 3, 2021
@franky47
Copy link
Member

franky47 commented Nov 3, 2021

Thanks for this !

@paul-emile-element paul-emile-element deleted the pe-send-159 branch November 3, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franky47 franky47 franky47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-emile-element @coveralls @franky47