react-native-app-auth module getting crashed in Android

[BajrangS]

Issue

Firebase crashlytics report below crash issue in react-native app Android. There is no issues in iOS.

Caused by java.lang.NullPointerException
Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference

com.rnappauth.RNAppAuthModule.onActivityResult (RNAppAuthModule.java:414)

---

Environment

• Your Identity Provider: e.g. IdentityServer 4 / Okta / Azure
  Unable to identify because this is NPM module level crash

• Platform that you're experiencing the issue on: iOS / Android / both
  Platform: Android

• Are you using Expo?
  No

Please provide suggestions to fix this issue.

Here's the crash log from my app

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
    at com.rnappauth.RNAppAuthModule.onActivityResult(RNAppAuthModule.java:419)
    at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:305)
    at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:762)
    at com.facebook.react.ReactDelegate.onActivityResult(ReactDelegate.java:90)
    at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:112)
    at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:68)
    at android.app.Activity.dispatchActivityResult(Activity.java:8304)
    at android.app.ActivityThread.deliverResults(ActivityThread.java:5006)
    at android.app.ActivityThread.handleSendResult(ActivityThread.java:5054)
    at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:51)
    at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:223)
    at android.app.ActivityThread.main(ActivityThread.java:7664)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=52, result=-1, data=Intent { dat=com.****.auth0://callback?code=**** (has extras) }} to activity {com.****/com.****.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
    at android.app.ActivityThread.deliverResults(ActivityThread.java:5013)
    at android.app.ActivityThread.handleSendResult(ActivityThread.java:5054)
    at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:51)
    at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:223)
    at android.app.ActivityThread.main(ActivityThread.java:7664)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
    
    ```

Same issue: #600

[mayzyo]

This might be a different reason for crashing, but I was able to resolve my crash by adding in
dangerouslyAllowInsecureHttpRequests: true

I don't know how to check android's native log so I am not sure if its the same error. But in my research to resolve my issue, I ended up here and issue #600 a couple times, so I hope this can help anyone suffering from the same error.

[Jay-A-McBee]

This issue occurs on low-end Android devices that kill the Activity when your app is backgrounded during the authentication process. We persist values in private instance fields so we can read/use them during the code/token exchange in our onActivityResult handler. We end up getting a null pointer exception because these values don't exist when we go to read them. Notice the first line in the posted stack trace

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
    at com.rnappauth.RNAppAuthModule.onActivityResult(RNAppAuthModule.java:419)

I've talked with the other maintainers and we are going to try to get around to a fix for this. I can't provide a timeline, but just a heads up that it's on our radar. There are a few issues in the repo where this is the root cause.

[jmacpherson]

Also investigating this issue presently. Can't help but notice that while Nirodha26#1 put in what may be a fix for this issue in January, the releases since then have not included this update.

Edit: My mistake, I see that that is on a fork. Any chance of that getting merged into official?

[DennisOstertag]

Also investigating this issue presently. Can't help but notice that while Nirodha26#1 put in what may be a fix for this issue in January, the releases since then have not included this update.

Edit: My mistake, I see that that is on a fork. Any chance of that getting merged into official?

@Jay-A-McBee any chance this possible fix would resove the issue and can be merged here ?

[nachoperez714]

It would be great if this fix was merged into official and added in a next release.

[asami95]

Hello @Jay-A-McBee
It does not just happen in low-end devices it also happens in so many high-end ones.
Is there any chance to get the PR merged or solve this issue?

[sandergo90]

Is there any update about this issue @Jay-A-McBee ?

[asohail-futu]

Are there any plans of including this change Nirodha26#1 in an official release to fix this issue?