This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Add support for stable branch of HTTP client library #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // master branch and patch in missing status and methods. | ||
| #ifndef HTTP_CODE_TEMPORARY_REDIRECT | ||
| #define HTTP_CODE_TEMPORARY_REDIRECT 307 | ||
| #define USE_STABLE_HTTPCLIENT_CORE |
There was a problem hiding this comment.
maybe rename that into USE_ARDUINO_CORE_2_0_0 as what is "stable" is likely to change over time.
|
LGTM just a small nits, can you also update the README.md file to point to the stable library. |
README: update arduino board definition link
Firebase: update arduino core define
proppy
added a commit
that referenced
this pull request
Feb 9, 2016
Add support for stable branch of HTTP client library
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.