Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Fixing deprecation warning on HttpClient begin #218

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

salqadri
Copy link
Contributor

@salqadri salqadri commented Oct 29, 2016

Was getting the following warnings:
/Users/foo/Documents/Arduino/libraries/firebase-arduino-master/src/FirebaseHttpClient_Esp8266.cpp: In member function 'virtual void FirebaseHttpClientEsp8266::begin(const string&, const string&)':
/Users/foo/Documents/Arduino/libraries/firebase-arduino-master/src/FirebaseHttpClient_Esp8266.cpp:31:86: warning: 'bool HTTPClient::begin(String, uint16_t, String, bool, String)' is deprecated (declared at /Users/foo/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.h:141) [-Wdeprecated-declarations]
http_.begin(host.c_str(), kFirebasePort, path.c_str(), true, kFirebaseFingerprint);

Followed the recommendation at https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.h:
bool begin(String host, uint16_t port, String uri, String httpsFingerprint); // deprecated, use the overload above instead bool begin(String host, uint16_t port, String uri, bool https, String httpsFingerprint) __attribute__ ((deprecated));

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@salqadri
Copy link
Contributor Author

I signed it!

@proppy
Copy link
Contributor

proppy commented Nov 1, 2016

Fixes #143

@proppy proppy merged commit 1a3f23e into FirebaseExtended:master Nov 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants