Updates the Web app to work with the new Firebase library #217
Conversation
| var firebaseUrl = 'https://example.firebaseio.com'; | ||
| var firebaseSecret = secret_or_token; | ||
| // NOTICE: Retrieve these values from the Firebase console to run the sample. | ||
| var firebaseDb = 'yourproject.firebaseio.com'; |
There was a problem hiding this comment.
you should also update the README instructions:
https://github.com/googlesamples/firebase-arduino/tree/master/examples/FirebaseNeoPixel_ESP8266#configuration
There was a problem hiding this comment.
Nit: we update that to match the placeholder in the sketch?
| 1. Go to the firebase hosting URL: `firebase-name.firebaseapp.com` | ||
| 1. Use the color picker and paint the NeoPixel table | ||
| 1. Watch the NeoPixel being updated to the matching color | ||
| 1. Go to the firebase hosting URL: `firebase-name.firebaseapp.com`. |
There was a problem hiding this comment.
shouldn't this be yourproject.firebaseapp.com to match what's before?
There was a problem hiding this comment.
Done. Looks like the docs are being overhauled though?
|
Not sure why the CI is failing :( |
|
It's saying |
|
I'm looking into it, a closer look shows: So I'm guessing that I should be using different variable names or constants somewhere. |
|
Ah yes, it's checking for https://github.com/firebase/firebase-arduino/blob/master/test/travis/firebase_init.cc.snip |
|
I need to squash an accidental commit of an experimental folder. |
|
Commits squashed, rogue experiment vanquished. |
| var firebaseUrl = 'https://example.firebaseio.com'; | ||
| var firebaseSecret = secret_or_token; | ||
| // NOTICE: Retrieve these values from the Firebase console to run the sample. | ||
| var firebaseDb = 'yourproject.firebaseio.com'; |
There was a problem hiding this comment.
Nit: we update that to match the placeholder in the sketch?
| @@ -54,7 +54,7 @@ firebase deploy | |||
|
|
|||
| ## Play | |||
|
|
|||
| 1. Go to the firebase hosting URL: `firebase-name.firebaseapp.com`. | |||
| 1. Go to the firebase hosting URL: `yourproject.firebaseapp.com`. | |||
There was a problem hiding this comment.
actually I was suggesting to rename the firebaseio.com url to match what's in the .ino file, but updating both also sounds good!
| 1. Select the board `Board > ESP8266 Modules > NodeMCU 1.0` | ||
| 1. Select the serial port `Port > /dev/tty...` | ||
| 1. Select the upload speed `Upload Speed > 115200` | ||
| 1. Click `Sketch > Upload` | ||
| 1. Open `public/index.html` with a text editor | ||
| 1. Replace `example.firebaseio.com` with the `Firebase Hostname` from step `2.` | ||
| 1. Replace `secret_or_token` with `Firebase Secret` from step `5.` | ||
| 1. Replace `yourproject.firebaseio.com` with the `Firebase Hostname` used for configuring the Arduino project. |
There was a problem hiding this comment.
I think we wants example.firebaseio.com everywhere.
Sorry for the lack of precision of the earlier comments.
There was a problem hiding this comment.
No worries, I'll change to be consistent with your checks.
No description provided.