This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Add other examples to travis #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All examples now compile (both non-tested ones were broken :( ). I can't fully test the neopixel one without hardware but it looks like it should still actually work. |
| @@ -21,7 +21,6 @@ | |||
| #include <ESP8266WiFi.h> | |||
| #include <Adafruit_GFX.h> | |||
| #include <Adafruit_SSD1306.h> | |||
| #include <ArduinoJson.h> | |||
There was a problem hiding this comment.
Since this is now built into our library you cannot include it directly.
|
LGTM, just nits over versioning, feel free to file a bug and merge. |
|
@gguuss can you test the neopixel sample once this is merged? |
|
Yes, I'll check soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.